Monday, 11 April 2016

Re: Storing updatedOn as UTC

Hi Warren,

Yes, the AdWords API .NET library assumes that UpdatedOn uses the same timezone as the server timezone. So if you use UpdatedOn in UTC and the server timezone is UTC+1, the library would always think that the token is expired.

Could you file a feature request on https://github.com/googleads/googleads-dotnet-lib/issues? I think the dates in general should be in UTC in OAuth classes; this is something we can address for an upcoming release.

Cheers,
Anash P. Oommen,
AdWords API Advisor.

On Thursday, April 7, 2016 at 4:49:18 AM UTC+8, Warren Zhang wrote:
Hey,

Looking at the code for OAuth2ProviderBase in the .NET library, it looks like the check for whether or not the access token is expiring compares against DateTime.Now. Would I ever run into any problems if I stored updatedOn as a UTC time and, say, the server's local timezone was set to >= UTC +1? 

Thanks,
Warren

--
--
=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~
Also find us on our blog and Google+:
https://googleadsdeveloper.blogspot.com/
https://plus.google.com/+GoogleAdsDevelopers/posts
=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~=~
 
You received this message because you are subscribed to the Google
Groups "AdWords API Forum" group.
To post to this group, send email to adwords-api@googlegroups.com
To unsubscribe from this group, send email to
adwords-api+unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/adwords-api?hl=en
---
You received this message because you are subscribed to the Google Groups "AdWords API Forum" group.
To unsubscribe from this group and stop receiving emails from it, send an email to adwords-api+unsubscribe@googlegroups.com.
Visit this group at https://groups.google.com/group/adwords-api.
To view this discussion on the web visit https://groups.google.com/d/msgid/adwords-api/6e65f72e-3624-48dc-a60d-700f88549b51%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

No comments:

Post a Comment